Changeset 57580

Timestamp:

02/09/2024 07:48:41 PM (6 months ago)

Author:

joedolson

Message:

Quick/Bulk Edit: Pre-fill category fields with their status.

Pre-fill category fields in the Quick/Bulk Edit form with their current status.

When bulk editing, if only some of the selected items are in a given category, the category's checkbox will display a line to indicate an indeterminate status.

Originally committed in [56172], but reverted due to a bug that removed all categories. Updated commit fixes the bug, adds unit tests, and improves the accessibility of the indeterminate state checkboxes.

Props pavelevap, scribu, chasedsiedu, helen, joshcanhelp, ubernaut, Cyberchicken, laumindproductscomau, SergeyBiryukov, Marcoevich, tomybyte, thinkluke, virtality-marketing-solutions, Michalooki, dmsnell, itecrs, pannelars, WHSajid, samba45, Mte90, johnbillion, tomluckies, soulseekah, francina, oglekler, ajmcfadyen, mukesh27, costdev, hellofromTonya, peterwilsoncc, joedolson, pbiron, oglekler, webcommsat, jorbin, ajmcfadyen, huzaifaalmesbah.
Fixes #11302.

Location:

trunk

Files:

• src/js/_enqueues/admin/inline-edit-post.js (modified) (2 diffs)
• src/wp-admin/css/list-tables.css (modified) (1 diff)
• src/wp-admin/includes/post.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/inline-edit-post.js

@@ -179 +179 @@
     setBulk : function(){
         var te = '', type = this.type, c = true;
+
+
         this.revert();
 
@@ -217 +219 @@
         // Populate the list of items to bulk edit.
         $( '#bulk-titles' ).html( '<ul id="bulk-titles-list" role="list">' + te + '</ul>' );
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
         /**

trunk/src/wp-admin/css/list-tables.css

@@ -1150 +1150 @@
 }
 
+
+
+
+
+
+
+
+
+
+
+
 #bulk-titles .ntdelbutton,
 #bulk-titles .ntdeltitle,

trunk/src/wp-admin/includes/post.php

@@ -650 +650 @@
 
         if ( isset( $new_cats ) && in_array( 'category', $tax_names, true ) ) {
-            $cats                       = (array) wp_get_post_categories( $post_id );
-            $post_data['post_category'] = array_unique( array_merge( $cats, $new_cats ) );
+            $cats = (array) wp_get_post_categories( $post_id );
+
+            if (
+                isset( $post_data['indeterminate_post_category'] )
+                && is_array( $post_data['indeterminate_post_category'] )
+            ) {
+                $indeterminate_post_category = $post_data['indeterminate_post_category'];
+            } else {
+                $indeterminate_post_category = array();
+            }
+
+            $indeterminate_cats         = array_intersect( $cats, $indeterminate_post_category );
+            $determinate_cats           = array_diff( $new_cats, $indeterminate_post_category );
+            $post_data['post_category'] = array_unique( array_merge( $indeterminate_cats, $determinate_cats ) );
+
             unset( $post_data['tax_input']['category'] );
         }

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -383 +383 @@
             $this->assertSame( 'aside', get_post_format( $post_id ) );
         }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
     }