Changeset 57288

Timestamp:

01/16/2024 03:21:45 AM (7 months ago)

Author:

peterwilsoncc

Message:

Login and Registration: Use correct variable to display a single error message.

When the wp_login_errors filter is used to add an error message followed by an instructional message, the former was not displayed and the latter was errouneously displayed twice above the login form.

This commit ensures that the error message is displayed as expected.

Follow-up to [56654].

Reviewed by jorbin.
Merges [57142] to the 6.4 branch.

Props mapumba, SergeyBiryukov.
Fixes #59983.

Location:

branches/6.4

Files:

• . (modified) (1 prop)
• src/wp-login.php (modified) (3 diffs)

branches/6.4/src/wp-login.php

@@ -258 +258 @@
                 $errors .= '</ul>';
             } else {
-                $errors .= '<p>' . $error_message . '</p>';
+                $errors .= '<p>' . $error_ . '</p>';
             }
 
@@ -266 +266 @@
              * @since 2.1.0
              *
-             * @param string $errors Login error message.
+             * @param string $errors Login error message.
              */
             $errors = apply_filters( 'login_errors', $errors );
+
             wp_admin_notice(
                 $errors,
@@ -288 +289 @@
              */
             $messages = apply_filters( 'login_messages', $messages );
+
             wp_admin_notice(
                 $messages,