Changeset 57178

Timestamp:

12/10/2023 10:34:12 AM (8 months ago)

Author:

zieladam

Message:

Build/Test Tools: Fix the workflow that posts a preview link on every Pull Request

Fixes a 403 error in the pull-request-comments.yml job by switching from a custom workflow dispatch call to the pull_request_target trigger.

Follow up to [57124], [57174].
Props ockham.
See #59416.

Location:

trunk/.github/workflows

Files:

• pull-request-comments.yml (modified) (6 diffs)
• test-build-processes.yml (modified) (3 diffs)

trunk/.github/workflows/pull-request-comments.yml

@@ -5 +5 @@
   pull_request_target:
     types: [ 'opened' ]
-  workflow_dispatch:
-    inputs:
-      pr_number:
-        description: 'The pull request number to process.'
-        required: true
-        type: string
+    branches:
+      - trunk
 
 # Cancels all previous workflow runs for pull requests that have not completed.
@@ -16 +12 @@
   # The concurrency group contains the workflow name and the branch name for pull requests
   # or the commit hash for any other events.
-  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request_target' && github.head_ref || github.event_name == 'workflow_dispatch' && inputs.pr_number || github.sha }}
-  cancel-in-progress: true
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request_target' && github.head_ref || github.event_name == 'workflow_dispatch' && github.event.number || github.sha }}
 
 # Disable permissions for all available scopes by default.
@@ -32 +27 @@
     timeout-minutes: 5
     if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name == 'pull_request_target' }}
-
     steps:
       - uses: wow-actions/welcome@72817eb31cda1de60f51893d80e2e82ce57f7e76 # v1.3.0
@@ -88 +82 @@
       issues: write
       pull-requests: write
-    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name == 'workflow_dispatch' }}
+    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name == '' }}
     steps:
       - uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
@@ -97 +91 @@
               owner: context.repo.owner,
               repo: context.repo.repo,
-              issue_number: context.payload.inputs.pr_number
+              issue_number: 
             };
             const comments = ( await github.rest.issues.listComments( commentInfo ) ).data;
@@ -123 +117 @@
             For more details about these limitations and more, check out the [Limitations page](https://wordpress.github.io/wordpress-playground/limitations/) in the WordPress Playground documentation.
 
-            [Test this pull request with WordPress Playground](https://playground.wordpress.net/wordpress.html?pr=${ context.payload.inputs.pr_number }).
+            [Test this pull request with WordPress Playground](https://playground.wordpress.net/wordpress.html?pr=${}).
             `;
 

trunk/.github/workflows/test-build-processes.yml

@@ -107 +107 @@
       directory: ${{ matrix.directory }}
 
-  # Calls the Pull Request Commenting workflow to leave a comment detailing how to test the PR within WordPress Playground.
-  playground-comment:
-    name: Leave WordPress Playground details
-    runs-on: ubuntu-latest
-    permissions:
-      actions: write
-    continue-on-error: true
-    needs: [ test-core-build-process, test-core-build-process-macos, test-gutenberg-build-process, test-gutenberg-build-process-macos ]
-    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name == 'pull_request' }}
-
-    steps:
-      - name: Dispatch workflow run
-        uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
-        with:
-          retries: 2
-          retry-exempt-status-codes: 418
-          script: |
-            github.rest.actions.createWorkflowDispatch({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              workflow_id: 'pull-request-comments.yml',
-              ref: 'trunk',
-              inputs: {
-                pr_number: '${{ github.event.number }}'
-              }
-            });
 
   slack-notifications:
@@ -140 +114 @@
       actions: read
       contents: read
-    needs: [ test-core-build-process, test-core-build-process-macos, test-gutenberg-build-process, test-gutenberg-build-process-macos, playground-comment ]
+    needs: [ test-core-build-process, test-core-build-process-macos, test-gutenberg-build-process, test-gutenberg-build-process-macos ]
     if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     with:
@@ -155 +129 @@
     permissions:
       actions: write
-    needs: [ playground-comment ]
+    needs: [  ]
     if: |
       always() &&