Changeset 56708

Timestamp:

09/26/2023 12:40:36 PM (11 months ago)

Author:

swissspidy

Message:

Sitemaps: do not list users who only authored pages.

Author archives are only generated for users who created at least one post.
Prevent adding author archives to the XML sitemap for users who only authored pages
as the links would otherwise result in a 404.

Props zodiac1978, huzaifaalmesbah.
Fixes #57816.

Location:

trunk

Files:

• src/wp-includes/sitemaps/providers/class-wp-sitemaps-users.php (modified) (1 diff)
• tests/phpunit/tests/sitemaps/wpSitemapsUsers.php (modified) (6 diffs)

trunk/src/wp-includes/sitemaps/providers/class-wp-sitemaps-users.php

@@ -137 +137 @@
         );
 
-        // We're not supporting sitemaps for author pages for attachments.
+        // We're not supporting sitemaps for author pages for attachments.
         unset( $public_post_types['attachment'] );
+
 
         /**

trunk/tests/phpunit/tests/sitemaps/wpSitemapsUsers.php

@@ -3 +3 @@
 /**
  * @group sitemaps
+
+
  */
 class Tests_Sitemaps_wpSitemapsUsers extends WP_UnitTestCase {
@@ -11 +13 @@
      * @var array
      */
-    public static $users;
+    p static $users;
 
     /**
@@ -18 +20 @@
      * @var int
      */
-    public static $editor_id;
+    p static $editor_id;
 
     /**
@@ -33 +35 @@
      * Test getting a URL list for a users sitemap page via
      * WP_Sitemaps_Users::get_url_list().
+
+
      */
     public function test_get_url_list_users() {
@@ -41 +45 @@
         $expected = array_map(
             static function ( $user_id ) {
-                $post = self::factory()->post->create_and_get( array( 'post_author' => $user_id ) );
+                ( array( 'post_author' => $user_id ) );
 
                 return array(
@@ -56 +60 @@
         $this->assertSameSets( $expected, $url_list );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }