Changeset 56236

Timestamp:

07/14/2023 09:45:05 PM (13 months ago)

Author:

azaozz

Message:

Menus: Fix critical errors when the page_on_front and/or page_for_posts options contain references to non-existing posts.

props: hbhalodia, wplindavantol, josklever, audrasjb.
Fixes: #58345.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (2 diffs)

trunk/src/wp-admin/includes/nav-menu.php

@@ -433 +433 @@
 
         $front_page_obj = null;
+
         if ( ! empty( $front_page ) ) {
-            $front_page_obj                = get_post( $front_page );
+            $front_page_obj = get_post( $front_page );
+        }
+
+        if ( $front_page_obj ) {
             $front_page_obj->front_or_home = true;
 
@@ -461 +465 @@
 
         if ( ! empty( $posts_page ) ) {
-            $posts_page_obj             = get_post( $posts_page );
-            $posts_page_obj->posts_page = true;
-
-            $important_pages[]   = $posts_page_obj;
-            $suppress_page_ids[] = $posts_page_obj->ID;
+            $posts_page_obj = get_post( $posts_page );
+
+            if ( $posts_page_obj ) {
+                $front_page_obj->posts_page = true;
+
+                $important_pages[]   = $posts_page_obj;
+                $suppress_page_ids[] = $posts_page_obj->ID;
+            }
         }