Changeset 55261

Timestamp:

02/07/2023 02:03:26 PM (18 months ago)

Author:

audrasjb

Message:

Privacy: Add rel="privacy-policy" to the Privacy Policy link.

This changeset adds a rel="privacy-policy" attribute to user-facing links to the Privacy Policy of the website, when a privacy policy page is set and available. While this rel value is still a RFC of the Link Types HTML specification, this changeset helps to make Privacy Policy link more discoverable for user agents and HTML parsers.

Props dshanske, audrasjb, bhavz-10, bookwyrm, faisal03, JeffPaul, peterwilsoncc, paapst, davidbaumwald, costdev, robinwpdeveloper, kawserz.
Fixes #56345.

Location:

trunk

Files:

• src/wp-includes/class-walker-nav-menu.php (modified) (1 diff)
• src/wp-includes/link-template.php (modified) (1 diff)
• tests/phpunit/tests/link/getThePrivacyPolicyLink.php (modified) (1 diff)
• tests/phpunit/tests/menu/walker-nav-menu.php (modified) (1 diff)

trunk/src/wp-includes/class-walker-nav-menu.php

@@ -183 +183 @@
             $atts['rel'] = $menu_item->xfn;
         }
-        $atts['href']         = ! empty( $menu_item->url ) ? $menu_item->url : '';
+
+        if ( ! empty( $menu_item->url ) ) {
+            if ( get_privacy_policy_url() === $menu_item->url ) {
+                $atts['rel'] = empty( $atts['rel'] ) ? 'privacy-policy' : $atts['rel'] . ' privacy-policy';
+            }
+
+            $atts['href'] = $menu_item->url;
+        } else {
+            $atts['href'] = '';
+        }
+
         $atts['aria-current'] = $menu_item->current ? 'page' : '';
 

trunk/src/wp-includes/link-template.php

@@ -4665 +4665 @@
     if ( $privacy_policy_url && $page_title ) {
         $link = sprintf(
-            '<a class="privacy-policy-link" href="%s">%s</a>',
+            '<a class="privacy-policy-link" href="%s">%s</a>',
             esc_url( $privacy_policy_url ),
             esc_html( $page_title )

trunk/tests/phpunit/tests/link/getThePrivacyPolicyLink.php

@@ -161 +161 @@
         return 'Policy: ' . $privacy_policy_url;
     }
+
+
+
+
+
+
+
+
+
+
+
 }

trunk/tests/phpunit/tests/menu/walker-nav-menu.php

@@ -153 +153 @@
         );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }