Changeset 54442

Timestamp:

10/10/2022 12:46:19 PM (22 months ago)

Author:

audrasjb

Message:

Upgrade/Install: Provide dirpath in error messages when _unzip_file_pclzip() cannot create directories.

This changeset ensures the directory path is provided in error messages when _unzip_file_pclzip() is unable to create a directory. This removes substr() which was returning an empty string in some use cases.

Props gunterer, SergeyBiryukov, n8finch, peterwilsoncc, audrasjb, rsiddharth, costdev , desrosj, mukesh27.
Fixes #54477.

File:

• trunk/src/wp-admin/includes/file.php (modified) (2 diffs)

trunk/src/wp-admin/includes/file.php

@@ -1708 +1708 @@
         // Only check to see if the Dir exists upon creation failure. Less I/O this way.
         if ( ! $wp_filesystem->mkdir( $_dir, FS_CHMOD_DIR ) && ! $wp_filesystem->is_dir( $_dir ) ) {
-            return new WP_Error( 'mkdir_failed_ziparchive', __( 'Could not create directory.' ), substr( $_dir, strlen( $to ) ) );
+            return new WP_Error( 'mkdir_failed_ziparchive', __( 'Could not create directory.' ),  );
         }
     }
@@ -1849 +1849 @@
         // Only check to see if the dir exists upon creation failure. Less I/O this way.
         if ( ! $wp_filesystem->mkdir( $_dir, FS_CHMOD_DIR ) && ! $wp_filesystem->is_dir( $_dir ) ) {
-            return new WP_Error( 'mkdir_failed_pclzip', __( 'Could not create directory.' ), substr( $_dir, strlen( $to ) ) );
+            return new WP_Error( 'mkdir_failed_pclzip', __( 'Could not create directory.' ),  );
         }
     }