Changeset 53414

Timestamp:

05/19/2022 03:52:03 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: List Tables: Hide the Comments column icon and title attribute from screen readers.

The element already has non-visual text, making the icon and the title attribute redundant for assistive technologies.

Follow-up to [22439], [27548], [31513], [32991], [50804].

Props sabernhardt, ryokuhi, afercia, karlgroves, SergeyBiryukov.
Fixes #55555. See #24766.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-media-list-table.php (modified) (1 diff)
• class-wp-posts-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -351 +351 @@
         if ( ! $this->detached ) {
             $posts_columns['parent'] = _x( 'Uploaded to', 'column name' );
+
             if ( post_type_supports( 'attachment', 'comments' ) ) {
-                $posts_columns['comments'] = '<span class="vers comment-grey-bubble" title="' . esc_attr__( 'Comments' ) . '"><span class="screen-reader-text">' . __( 'Comments' ) . '</span></span>';
+                $posts_columns['comments'] = sprintf(
+                    '<span class="vers comment-grey-bubble" title="%1$s" aria-hidden="true"></span><span class="screen-reader-text">%2$s</span>',
+                    esc_attr__( 'Comments' ),
+                    __( 'Comments' )
+                );
             }
         }

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -692 +692 @@
         ) {
             $posts_columns['comments'] = sprintf(
-                '<span class="vers comment-grey-bubble" title="%1$s"><span class="screen-reader-text">%2$s</span></span>',
+                '<span class="vers comment-grey-bubble" title="%1$s"</span>',
                 esc_attr__( 'Comments' ),
                 __( 'Comments' )