Changeset 34030

Timestamp:

09/11/2015 01:25:21 AM (9 years ago)

Author:

pento

Message:

Schema: Increase the length of wp_options.option_name.

It's pretty easy to run over the option_name length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from VARCHAR(64) to VARCHAR(191) significantly reduces the risk of this occurring.

Because option_name has a UNIQUE index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.

Location:

trunk/src

Files:

• wp-admin/includes/schema.php (modified) (1 diff)
• wp-admin/includes/upgrade.php (modified) (2 diffs)
• wp-includes/version.php (modified) (1 diff)

trunk/src/wp-admin/includes/schema.php

@@ -136 +136 @@
 CREATE TABLE $wpdb->options (
   option_id bigint(20) unsigned NOT NULL auto_increment,
-  option_name varchar(64) NOT NULL default '',
+  option_name varchar() NOT NULL default '',
   option_value longtext NOT NULL,
   autoload varchar(20) NOT NULL default 'yes',

trunk/src/wp-admin/includes/upgrade.php

@@ -538 +538 @@
     if ( $wp_current_db_version < 33056 )
         upgrade_431();
+
+
+
 
     maybe_disable_link_manager();
@@ -1597 +1600 @@
 
 /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
  * Executes network-level upgrade routines.
  *

trunk/src/wp-includes/version.php

@@ -12 +12 @@
  * @global int $wp_db_version
  */
-$wp_db_version = 33056;
+$wp_db_version = 3;
 
 /**