commit 8a35fc6c8e8d095c12640fb43a5f5135eaa195d2
author Andreu Botella <abotella@igalia.com> Fri Jul 12 04:49:28 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 12 04:49:28 2024
tree 2309d3a11bb0e2b2b2fb22c0acc86c2078d1468b
parent cd9fb7e249f7c299fdd600628ad08a06f0dc9ec8

[line-clamp] [RubyLB] Make sure ruby isn't visible in clamped lines

With RubyLB, in some cases ruby annotations would not be hidden even
though the line containing them would be. This is because when a line
is after the clamp point, the line box and its logical line items
would be marked as hidden for paint, but in RubyLB the line's ruby
annotations and their line items are stored in the logical ruby
columns.

This patch fixes this in `FragmentItemsBuilder::AddLine`, when
`FragmentItem`s are created for a line's multiple annotations, by
marking every item in the annotations as hidden for paint if the
line's fragment is marked as such.

Aside from adding a test for this issue, this patch also adds a test
that the sizing of a clamped block box properly takes into account any
ruby annotations that add leading to a line. This already worked as
expected, presumably due to https://crrev.com/c/5683304 storing the
`PreviousInflowPosition` at the clamp point, but the effect on ruby
had not been tested in that CL.

Bug: 40336192
Change-Id: I95fe796bb887d1d205dd43c2644095b6c6f225e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5695646
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Andreu Botella <abotella@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1326551}