Details
Details
- Reviewers
alwu - Group Reviewers
media-playback-reviewers - Commits
- rMOZILLACENTRALf9eb1d015824: Bug 1878510 - When recreating WebM demuxer when encountering a new segment…
- Bugzilla Bug ID
- 1878510
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Code analysis found 3 defects in diff 878257:
- 1 defect found by clang-format
- 2 defects found by clang-format (Mozlint)
WARNING: Found 3 defects (warning level) that can be dismissed.
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
- ./mach clang-format -p dom/media/webm/WebMDemuxer.cpp
For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 878257.
Comment Actions
: We will try to see if we can generate test for this, but now we want it to be landed ASAP.
| dom/media/webm/WebMDemuxer.h | ||
|---|---|---|
| 228 | nits : Although I was using video at the first time, this is better to rename to mFrameEndTimeBeforeReset. Same for other patches. | |
| dom/media/webm/WebMDemuxer.h | ||
|---|---|---|
| 228 | I will do it in a follow-up bug. | |