Details
- Reviewers
nshukla - Group Reviewers
win-reviewers firefox-desktop-core-reviewers - Commits
- rMOZILLACENTRAL47ef798eb7e5: Bug 1901840 - restore browser.privateWindowSeparation.enabled pref r=nshukla…
- Bugzilla Bug ID
- 1901840
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable - Build Status
Buildable 672844 Build 771963: arc lint + arc unit
Event Timeline
This looks good to me. I'm not sure whether we want testing here but as I'll be on PTO for the next week I'll leave that to other reviewers to decide.
Code analysis found 1 defect in diff 876288:
- 1 defect found by clang-format
You can run this analysis locally with:
- ./mach clang-format -p widget/windows/nsWindow.cpp
For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 876288.
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!
1 defect closed compared to the previous diff 876288.
If you see a problem in this automated review, please report it here.