Bug 1901840 - restore browser.privateWindowSeparation.enabled pref r=nshukla!
ClosedPublic

Authored by Erchen on Jun 13 2024, 6:45 PM.
Referenced Files
Unknown Object (File)
Thu, Jul 25, 12:11 PM
Unknown Object (File)
Tue, Jul 9, 1:13 PM
Unknown Object (File)
Sat, Jun 29, 5:16 PM
Unknown Object (File)
Jun 27 2024, 10:46 PM
Unknown Object (File)
Jun 27 2024, 10:45 PM
Unknown Object (File)
Jun 25 2024, 8:05 AM
Unknown Object (File)
Jun 17 2024, 12:08 PM
Unknown Object (File)
Jun 15 2024, 4:45 PM

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 672844
Build 771963: arc lint + arc unit

Event Timeline

Erchen created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Jun 13 2024, 6:45 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Erchen updated this revision to Diff 876288.
Erchen retitled this revision from WIP: Bug 1901840 - restore browser.privateWindowSeparation.enabled pref r=nshukla! to Bug 1901840 - restore browser.privateWindowSeparation.enabled pref r=nshukla!.
Erchen added a reviewer: nshukla.

This looks good to me. I'm not sure whether we want testing here but as I'll be on PTO for the next week I'll leave that to other reviewers to decide.

Code analysis found 1 defect in diff 876288:

  • 1 defect found by clang-format
WARNING: Found 1 defect (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach clang-format -p widget/windows/nsWindow.cpp

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 876288.

This revision is now accepted and ready to land.Jun 14 2024, 9:13 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

mak added a subscriber: mak.

separation feature is tested apart, this is just the feature pref.

1 defect closed compared to the previous diff 876288.


If you see a problem in this automated review, please report it here.